Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when starting containers with rogue containers already present #381

Merged
merged 2 commits into from
Mar 30, 2017
Merged

Error when starting containers with rogue containers already present #381

merged 2 commits into from
Mar 30, 2017

Conversation

stefanoborini
Copy link
Contributor

Fixes #380

@codecov-io
Copy link

codecov-io commented Mar 29, 2017 •
edited
Loading

Codecov Report

Merging #381 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #381      +/-   ##
=========================================
- Coverage   95.35%   95.3%   -0.05%     
=========================================
  Files          92      92              
  Lines        3939    3941       +2     
  Branches      254     255       +1     
=========================================
  Hits         3756    3756              
- Misses        126     128       +2     
  Partials       57      57
Impacted Files Coverage Δ
...eappmanager/docker/tests/test_container_manager.py 100% <ø> (ø) ⬆️
remoteappmanager/docker/container_manager.py 86.47% <100%> (+0.13%) ⬆️
...eappmanager/tests/mocking/virtual/docker_client.py 89.06% <0%> (-1.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07d31a2...2faaa60. Read the comment docs.

@stefanoborini
Copy link
Contributor Author

Coverage decrease due to lack of use of a test utility function, not over the actual code.

@stefanoborini stefanoborini merged commit cc74f46 into master Mar 30, 2017
@stefanoborini stefanoborini deleted the 380-error-when-starting branch March 30, 2017 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefanoborini @codecov-io @martinRenou